Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add address and customer metadata to tax calc context #10122

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

srindom
Copy link
Collaborator

@srindom srindom commented Nov 15, 2024

Fixes CMRC-713

What

  • Ensure that customer and shipping address metadata is passed in the tax calculation context when updating tax lines on a cart.

Why

@srindom srindom requested a review from a team as a code owner November 15, 2024 15:48
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 3:51pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Nov 15, 2024 3:51pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 3:51pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 3:51pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 3:51pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2024 3:51pm
resources-docs ⬜️ Ignored (Inspect) Nov 15, 2024 3:51pm

Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: cb40147

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -2159,6 +2160,44 @@ medusaIntegrationTestRunner({
])
})
})

describe("updateTaxLinesWorkflow", () => {
it("should create a payment collection and link it to cart", async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it("should create a payment collection and link it to cart", async () => {
it("should include shipping address metadata in tax calculation context", async () => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants